Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0] Test: Fix liveness_test.py integration test flakiness #661

Merged
merged 1 commit into from
Aug 28, 2024
Merged

[1.0] Test: Fix liveness_test.py integration test flakiness #661

merged 1 commit into from
Aug 28, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Aug 28, 2024 •
edited
Loading

  • Disable production pause on missing votes since the test stops finality as part of the test.
  • Enable stale production on restart of production node as it is a producer and it might be its time to produce.

Resolves #653
Resolves #620

@heifner heifner requested review from linh2931 and greg7mdp August 28, 2024 13:42
@heifner heifner added the OCI Work exclusive to OCI team label Aug 28, 2024
@heifner heifner changed the base branch from main to release/1.0 August 28, 2024 13:43
@heifner heifner linked an issue Aug 28, 2024 that may be closed by this pull request
Test failure: liveness_test #620
Closed
@heifner heifner merged commit bc9a39d into release/1.0 Aug 28, 2024
36 checks passed
@heifner heifner deleted the GH-653-liveness-test branch August 28, 2024 15:35
This was referenced Aug 28, 2024
Merged
Merged
Merged
@ericpassmore
Copy link
Contributor

Note:start
group: STABILITY
category: TEST
summary: Update liveness tests to be more robust and less flaky.
Note:end

@ericpassmore ericpassmore added bug The product is not working as was intended. test-instability tag issues for flaky tests, high priority to address labels Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arhag arhag arhag approved these changes

@greg7mdp greg7mdp greg7mdp approved these changes

@linh2931 linh2931 Awaiting requested review from linh2931

Assignees
No one assigned
Labels
bug The product is not working as was intended. OCI Work exclusive to OCI team test-instability tag issues for flaky tests, high priority to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test failure: liveness_test Test failure: liveness_test
4 participants
@heifner @ericpassmore @greg7mdp @arhag